google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library

Home Page:https://flatbuffers.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

CMake: use target compile features cxx_std_11 instead of hardcoded flags and regardless of toolchain file

SpaceIm opened this issue · comments

The main CMakeLists requires CMake >= 3.16. Therefore it should rely on target_compile_features(<target> PUBLIC cxx_std_11) regardless of whether toolchain file is used or not, instead of hardcoded flags like -std=c++11.

Yes, this was my plan with upgrading the min cmake version. PRs welcomed! Otherwise, I'll get to it at some point

If I can find some time to work on this and it's not implemented in the meantime, I'll submit a PR ;)