google / flatbuffers

FlatBuffers: Memory Efficient Serialization Library

Home Page:https://flatbuffers.dev/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Publish a 2.0.5 release?

fjarri opened this issue · comments

Somewhere between Flatbuffers 2.0.0 and 2.0.5 (current) there has been a backwards incompatible change in how generated Rust files are laid out (#6731, if I'm not mistaken). The current published release is 2.0.0, so it creates conflicts when, say, it is used on CI, while developer machines may have a newer version (e.g. homebrew has only 2.0.5 available). Would it be possible to update the release?

@CasperN Does rust need a version increase and release?

A published 2.0.5 on npm would be nice as well. The current published version 2.0.4 is incompatible since the BigInt change (ace4a37)

Does rust need a version increase and release?

The change in how files are laid out is in flatc so the next flatc release should have been 3.0, not 2.0.5

However I think we could make the new file layout behavior opt-in rather than by default and call it a patch

Hmm, this is where versioning would get really messy. I feel like jumping to 3.0 signals to everyone that their are major changes, yet it just a small change to one language.

I feel like jumping to 3.0 signals to everyone that their are major changes, yet it just a small change to one language.

Agreed, I can change the default to be non-breaking. I didn't expect that we'd release again so soon, or that we'd have any non-major releases, so I'm happy if this means we're releasing more

We are at v2.0.6 now. @CasperN do you want to do the pushing of the rust cargo package?

Done - I just published it, but note that the fix for this issue didn't have to do with the cargo package, and also the cargo package is now at 2.1.0 because we added no-std support.

Any updates on this? It would be nice to have a release with #7273.