google / error-prone

Catch common Java mistakes as compile-time errors

Home Page:https://errorprone.info

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Errorprone not an OSGi bundle

Lana11s opened this issue · comments

Currently, com.google.errorprone.annotations (version 2.10.0) is not an OSGi bundle. Some entries are missing in MANIFEST.MF:

Manifest-Version: 1.0
Automatic-Module-Name: com.google.errorprone.annotations
Archiver-Version: Plexus Archiver
Built-By: cushon
Created-By: Apache Maven 3.6.3
Build-Jdk: 1.8.0_202

Would be great if you can change this. Would allow us to upgrate to google/guice 5.1.0

I don't know very much about OSGi. Is this a regression from earlier versions of Error Prone? Do you know what changed in guice 5.1.0 that worked previously?

Hello @cushon,
I looked into previous releases of error-prone (incl. 2.0) and manifest file had the same structure.
Guice worked in the OSGi environment because the dependency to error-prone was introduced with 5.1.0.
I am not familiar with Maven Jar Plugin, but it seems that it needs some configuration so that entries (like import-package, export-package) are added: https://maven.apache.org/plugins/maven-jar-plugin/examples/manifest-customization.html