google / codesearch

Fast, indexed regexp search over large file trees

Home Page:http://swtch.com/~rsc/regexp/regexp4.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Line missing in read.go

GoogleCodeExporter opened this issue · comments

Queries of the type [Hh]ashTable fail to yield results, where hashTable and 
HashTable each gets results.
It seems like a line is clearly missing in read.go in method:
  func (r *postReader) init(ix, trigram, restrict)
so that the restrict parameter is ignored.

The attached patch adds a test that shows the bug and fixes the problem.


Original issue reported on code.google.com by ugodi...@gmail.com on 15 Apr 2012 at 3:59

  • Merged into: #8

Attachments:

The [Hh]ashtable problem is actually an issue with the regex engine, reported 
and fixed as issue #8.  The "restrict isn't initialized" bug is issue #16, also 
with a patch.

I should poke Russ Cox to release a new version of codesearch, as there are a 
number of patches sitting un-merged on the bug tracker.

Original comment by dgryski on 16 Apr 2012 at 8:53

  • Added labels: ****
  • Removed labels: ****
Thank you, that would be great!

Original comment by ugodi...@gmail.com on 16 Apr 2012 at 6:26

  • Added labels: ****
  • Removed labels: ****

Original comment by dgryski on 2 May 2012 at 8:54

  • Changed state: Duplicate
  • Added labels: ****
  • Removed labels: ****