logocert_api branch: (Propose) testLocalDiscoveryToggle()

Question

logocert_api branch: (Propose) testLocalDiscoveryToggle()

YoshimiMorita opened this issue 8 years ago · comments

Hi Kelly-san/Kevin-san/GCPTeam,

About testLocalDiscoveryToggle() test:

In some printers,
when toggled off local discovery, local printing will toggle off (disabled) too.

So that, local printing may remain OFF (disabled) after this test.
Then, subsequent 'LocalPrinting' test suite will be failed.

I think that it is necessary to explicitly process to enable local printing.

Regards,
Yoshimi Morita

Kelly Lucas · Answer 1 · Wed Feb 01 2017 03:07:11 GMT+0800 (China Standard Time)

Yoshimi-san,

We discussed this internally and decided to put a post test check in to see what state Local Printing is in, and to toggle is back if it's still turned off. We've seen various behavior with different printers, so it seems a check is needed.

chok · Answer 2 · Wed Feb 01 2017 03:11:58 GMT+0800 (China Standard Time)

Yoshimi-san,

Thanks for bringing this to our attention.
As Kelly said, we have added a check to make sure local printing remains on after the testLocalDiscoveryToggle() test. Please pull and give it a try.

Thanks,
Kevin

YoshimiMorita · Answer 3 · Wed Feb 01 2017 17:41:39 GMT+0800 (China Standard Time)

Hi Kelly-san/Kevin-san,

I confirm this change, it works well.
Thank you for accepting my proposal.

I will close this.

Thanks,
Yoshimi Morita