google / cityhash

Automatically exported from code.google.com/p/cityhash

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Warning on build.

GoogleCodeExporter opened this issue · comments

What steps will reproduce the problem?
1. Build for x64 gcc with -Wsign-compare.
2. Observe warning.

What is the expected output? What do you see instead?
No warnings.

../../third_party/externals/cityhash/src/city.cc:146:21: warning: comparison of 
integers of different signs: 'int' and 'size_t' (aka 'unsigned long') 
[-Wsign-compare]
  for (int i = 0; i < len; i++) {
                  ~ ^ ~~~
1 warning generated.


What version of the product are you using? On what operating system?
Revision 11.

Please provide any additional information below.
Patch attached. With patch the exact same code appears to be generated (with 
Release style compile settings) but no warning diagnostic is emitted.

Original issue reported on code.google.com by bunge...@google.com on 7 Dec 2012 at 5:01

Attachments:

Original comment by gp...@google.com on 20 Jun 2013 at 10:03

  • Changed state: Accepted

Original comment by gp...@google.com on 31 Jul 2013 at 11:41

  • Changed state: Fixed