google / carfac

Cascade of Asymmetric Resonators with Fast-Acting Compression (CARFAC) cochlear model.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

EMSCRIPTEN_PATH and emscripten usage well out-of-date (cpp builds broken with recent tools)

sedurCode opened this issue · comments

Hi,
Freshly attempting to perform C++ builds using scons, I installed the dependencies as described in the SConstruct script on Ubuntu 1804.
However, the environment variables reference in the SConstruct for this project do not match those used/created-by emscripten

Also, the linked documentation for installing emscriptenv on ubuntu no longer exists.

commented

Thanks for pointing this out!

Since you seem familiar with the issue, would you be willing to create a pull request that fixes the issues?

You'd have to follow the instructions in https://opensource.google/docs/releasing/template/CONTRIBUTING/ (unless you already have).

Sorry its taken me a couple days.
Ive had a branch ready since Friday, but it would be great if you could test it in your environment to be sure it won't break everything.