google / GoogleSignIn-iOS

Enables iOS and macOS apps to sign in with Google.

Home Page:https://developers.google.com/identity/sign-in/ios

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Calling GIDSignIn.sharedInstance.signIn, no callback is returned after successful authentication

taro-ken opened this issue · comments

Describe the bug
Calling GIDSignIn.sharedInstance.signIn, no callback is returned after successful authentication

To Reproduce
Steps to reproduce the behavior:

  1. Press the GoogleLogin button and call the GIDSignIn.sharedInstance.signIn method
  2. Select a valid Google account and proceed
  3. permit access

Expected behavior
Closure returns a signInResult.

Screenshots

2024-03-09.11.09.14.mov

Environment

  • Device: [ iPhone 14 simulator, M2 MacBook Air ]
  • OS: [ iOS 17.0, macOS 13.5 ]

Additional context
Pressing the GoogleLogin button to cancel the permission to share information dialog about apps and websites successfully returns an error in Closure.

I am not sure how the "GoogleLogin" button works. Ultimately, I think it would be that button's job to make sure that the closure is called. The sample apps in this library do not see this issue.

If you're able to reproduce this issue in one of our sample apps, please comment here with exact reproduction steps and we will investigate.