Documentation Issue - from_keras_model function

Question

Documentation Issue - from_keras_model function

Barathwaja opened this issue 9 months ago · comments

Describe the bug
The latest API documentation states that from_keras_model is accessible from tff.learning.models but some of the pages still uses old way approach via tff.learning (i.e tff.learning.from_keras_model) instead of tff.learning.models.from_keras_model.

API Documentation - https://www.tensorflow.org/federated/api_docs/python/tff/learning/models/from_keras_model
Bug Pages - https://www.tensorflow.org/federated/tutorials/loading_remote_data

Expected behavior
This is where it should be imported as tff.learning.models.from_keras_model

Screenshot
Attached screenshot below:

Zachary Charles · Answer 1 · Mon Oct 02 2023 23:37:30 GMT+0800 (China Standard Time)

Thanks @Barathwaja! That tutorial looks stale. I'll try to have it updated today.

Barathwaja S · Answer 2 · Mon Oct 02 2023 23:46:38 GMT+0800 (China Standard Time)

@zcharles8 I can update and make a PR if that's is the only change needed.

Zachary Charles · Answer 3 · Tue Oct 03 2023 08:44:03 GMT+0800 (China Standard Time)

As it turns out, this tutorial was already deleted, as it is stale. However, we are blocked on releasing a new TFF version until we figure out some compatibility issues, and the TF docs won't update until that happens. Marking this as resolved as a result.