Giters

google-deepmind / open_spiel

OpenSpiel is a collection of environments and algorithms for research in general reinforcement learning and search/planning in games.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Block dominoes implementation

Brunozml opened this issue · comments

commented

Hi, I'm looking to solve a version of block dominoes for my bachelor's thesis and I would like to contribute to OpenSpiel's implementation (which seems to be incomplete, as tests fail and it is not currently on the list of registered games); However, I'm having trouble grasping how to contribute in this domain.

commented

Hi @Brunozml,

Block dominoes should be on games list.. here:

open_spiel/open_spiel/python/tests/pyspiel_test.py

Line 109 in 1b09f3b

"python_block_dominoes",

It's a python game, so I guess you were not finding it because if the missing python_ prefix.

Anyway it should be included in the basic game simulations test (python/tests/games_sim_test.py) as well as its own test here: https://github.com/google-deepmind/open_spiel/blob/master/open_spiel/python/games/block_dominoes_test.py.

Which tests are failing for you? Can you paste the errors?

commented

Hi @lanctot,

Thank you for your reply, I hadn't noticed the python_ prefix. The errors were due to some tinkering I had been doing to the block_dominoes.py file.