dqn.cc build error

[ljrrjl]

dqn.cc build error

Hello, I encountered an error during the recent compilation process.

error output

 error: return-statement with no value, in function returning 'open_spiel::Action' {aka 'long int'} [-fpermissive]

Compile parameters

• OPEN_SPIEL_BUILD_WITH_PYTHON=OFF
• OPEN_SPIEL_BUILD_WITH_LIBNOP=ON
• OPEN_SPIEL_BUILD_WITH_LIBTORCH=ON
• BUILD_SHARED_LIB=ON
• gcc 9.4.0

My Solution

I can compile by simply returning 0 but I don't know if it is correct.

open_spiel/open_spiel/algorithms/dqn_torch/dqn.cc

Line 40 in 16d21cf

 return; 

[lanctot]

Ah yes, good catch. Compilers are too leanient these days... :)

That should be return kInvalidAction;

That's easy enough for me to fix on my end, but I like to encourage people to submit a PR fix to get the public credit. Do you have a preference?

[lanctot]

Fixed by b85fd24

Thanks!