Giters

google-deepmind / deepmind-research

This repository contains implementations and illustrative code to accompany DeepMind publications

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Missing flag definitions

zahidirfan opened this issue · comments

commented

The shell script run_adult_pscf.sh passes the flags: dataset_dir and numstep but they are not defined in the following file.

Ref to line in script.
https://github.com/deepmind/deepmind-research/blob/cb555c241b20c661a3e46e5d1eb722a0a8b0e8f4/counterfactual_fairness/run_adult_pscf.sh#L36

https://github.com/deepmind/deepmind-research/blob/cb555c241b20c661a3e46e5d1eb722a0a8b0e8f4/counterfactual_fairness/adult_pscf.py#L41
The solution is to define the flags as follows. The default values I have chosen are arbitrary.

flags.DEFINE_string ("dataset_dir", "", "Sets the dataset directory")
flags.DEFINE_string ("num_steps", "10", "Sets the number of steps")