Giters

golemfactory / golem-electron

Graphical user interface for Golem Project

Home Page:https://golem.network

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Withdrawing deposit to your own account looks different for GNT and ETH

cr44d opened this issue · comments

commented

Description

Golem Version: Brass Golem v0.22.1

Golem-Messages version (leave empty if unsure):

Electron version: Golem Interface v0.2.4

OS [e.g. Windows 10 Pro]: Windows 10 Home

Branch (if launched from source):

Mainnet/Testnet: Mainnet

Priority label is set to the lowest by default. To setup higher priority please change the label
P0 label is set for Severity-Critical/Effort-easy
P1 label is set for Severity-Critical/Effort-hard
P2 label is set for Severity-Low/ Effort-easy
P3 label is set for Severity-Low/Effort-hard

Description of the issue:
I use "Withdraw" with my own Golem's address.
With GNT everything is as I expect: there are two operations in Transaction History, first with negative amount and the second with positive.
For ETH this looks differently: there is only one transaction. And it is the one with negative amount, which may be very distressing for the user.

On the bright side, payment in fact works as expected (you only lose the transaction fee), but I see two problems:

  1. It's inconsistent. The behavior is different for GNT and for ETH.
  2. For sure ETH behavior is wrong.

Actual result:

For ETH transfers to your own account you see only withdrawal transaction.

Screenshots:

image

Steps To Reproduce

  1. Launch the app.
  2. Expand deposit details.
  3. Copy your wallet's address.
  4. Click "Withdraw" (either for GNT or ETH)
  5. Paste the address and put the amount (or press "copy balance").
  6. Click "Apply".

Expected behavior and proposed solution

I see two possible fixes and I'm not sure which would be best:

  1. Make ETH behave in the same way as GNT, i.e. show two transactions, with negative and positive change.
  2. Stick with one transaction, but make the change 0 ETH.
    I would choose the first one, but I don't think it's obviously better.
commented

This is more related with @jiivan I believe.

commented

It's an issue with a reliable way of detecting ETH incomes. Unfortunatelly it's complicated & AFAIR sending ETH to yourself is one of those complicated edge cases.