Support graceful shutdown

Question

Support graceful shutdown

kmazurek opened this issue 5 years ago · comments

Golem core includes logic for shutting down gracefully (if there are any tasks running, core is put into a state where it does not accept any new tasks and waits for the pending ones to finish before shutting down). This state can be toggled using the RPC golem.graceful_shutdown.

This could be utilised in Electron, with shutdown state being triggered on exit and toggled off (if necessary) when Electron is started again.

Muhammed Tanrıkulu · Answer 1 · Fri Mar 08 2019 22:40:20 GMT+0800 (China Standard Time)

So the only required parameter is boolean I suppose?

Kuba Mazurek · Answer 2 · Fri Mar 08 2019 23:14:10 GMT+0800 (China Standard Time)

@jamuszyn As discussed, this will require some design work from you. @mdtanrikulu What parameter do you mean here?

Muhammed Tanrıkulu · Answer 3 · Fri Mar 08 2019 23:19:37 GMT+0800 (China Standard Time)

@zakaprov For the RPC usage, to toggle etc.

graceful_shutdown(true, "some other paramter if needed")

Kuba Mazurek · Answer 4 · Mon Mar 11 2019 17:57:25 GMT+0800 (China Standard Time)

The relevant RPC (golem.graceful_shutdown) takes no parameters, it works as a simple toggle. The status for the shutdown is returned in the response from the RPC (enum ShutdownResponse in Golem core). Any feedback for the user should be based on this response.