goldmansachs / gs-quant

Python toolkit for quantitative finance

Home Page:https://developer.gs.com/discover/products/gs-quant/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Remove pandas version restriction

theavey opened this issue · comments

Describe the problem.
There are bug fixes and features available in newer versions of pandas that I would like to have access to.
In my non-thorough testing, this package works just fine with newer versions of pandas (1.2.0).

Describe the solution you'd like
Testing of the package with the version constraint removed followed by removing the version restriction.

Describe alternatives you've considered
I currently just have multiple environments with different package versions to work around this restriction.
If there are issues found, the restriction is reasonable to remain, but I would be willing to help fix issues that are found.

Are you willing to contribute
Yes

Additional context
Because pandas follows semantic versioning, there should be no breaking changes going from 1.0 to 1.2 unless you are relying on some internal implementation details in pandas or a bug.

Thanks for reaching out theavey! This is great advice and we are looking into this internally.

https://iscinumpy.dev/post/bound-version-constraints/

On a related note, we had some issues internally when #211 was merged, which included a quite restrictive matplotlib version specification

Thanks Tom, will look into that one too.