goldbergyoni / javascript-testing-best-practices

πŸ“—πŸŒ 🚒 Comprehensive and exhaustive JavaScript & Node.js testing best practices (July 2023)

Home Page:https://testjavascript.com/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

How to add contributor to list?

goldbergyoni opened this issue Β· comments

@js-kyle Layman question - when I approve John Doe's PR, will he be added automatically to the list or should I do anything manual?

It isn't fully automated - when you want to add a contributor, you request the bot to add them by mentioning it in an issue comment, by using the command

@all-contributors-bot please add @goldbergyoni for content

https://github.com/goldbergyoni/nodebestpractices/blob/master/.operations/CONTRIBUTING.md#other-contributions-

It seems the bot isn't working as it should today :(

I will try it again soon - there might be an outage to the service

@all-contributors-bot please add @goldbergyoni for content

OK, let me try

@all-contributors-bot please add @js-kyle for content

That's easy, even I can do this. Ping once it's up again and I'll add the latest contributos

Does the bot still have access to the repository? It is a bit strange it isn't working anymore

@all-contributors-bot please add @goldbergyoni for content

@all-contributors please add @goldbergyoni for content

@js-kyle

I've put up a pull request to add @goldbergyoni! πŸŽ‰

Okay @goldbergyoni I just had the command wrong the whole time πŸ˜…

I can see you've worked this out out - it works the same way as on the nodebestpractices repo