Is there a plan to add support for Go modules?

Question

Is there a plan to add support for Go modules?

easwars opened this issue 5 years ago · comments

Easwar Swaminathan commented 5 years ago

This is a request from the gRPC-Go team.
We plan to use the LRU cache implementation found here and would be nice if groupcache had Go modules support.

I can send a PR for the same if you are OK.

Easwar Swaminathan commented 5 years ago

Thanks.

Brad Fitzpatrick · Answer 1 · Thu Jan 09 2020 11:25:43 GMT+0800 (China Standard Time)

You mean just adding a go.mod file? It should work without one, but sure. Feel free to send a PR.

How is gRPC-Go using groupcache?

Easwar Swaminathan · Answer 2 · Thu Jan 09 2020 13:56:50 GMT+0800 (China Standard Time)

We are only interested in using the LRU implementation from groupcache. We plan to use that in one of the loadBalancing policy implementations where we need to cache the responses from a management server.

On second thoughts, maybe we should just duplicate that code.

Brad Fitzpatrick · Answer 3 · Thu Jan 09 2020 14:25:03 GMT+0800 (China Standard Time)

Yeah, I'd just duplicate it. There are many LRU implementations around with various properties too.