[json type number] proto type int64 should be string
scbizu opened this issue · comments
Nice catch
Would you like to attempt a fix or do you think this is simply a known
issue?
…On Thu, 20 Dec 2018 at 09:02, scnace ***@***.***> wrote:
Background:
isNumber <https://github.com/gogo/letmegrpc/blob/master/form/form.go#L441>
function will convert protobuf type int64 to json type number, but the
number's precision is not equal to int64 , see the spec
<https://developers.google.com/protocol-buffers/docs/proto3#json> about
the proto json.
Reproduce:
[image: image]
<https://user-images.githubusercontent.com/8732481/50269116-4018fc80-0468-11e9-84e0-c1fe7df96a7a.png>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#52>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLZulA7WdrtUGcHjNpvCkgV0QsA6Iks5u6zYSgaJpZM4Zbn_J>
.
I want to develop a grpc tool to quickly debug my grpc methods. And I finally find that letmegrpc impl most of my feature, I am reading through letmegrpc now and doing some changes.
So, I think I can provide a PR to solve this issue.
Awesome that would be great.
…On Fri, 21 Dec 2018 at 04:50, scnace ***@***.***> wrote:
I want to develop a grpc tool to quickly debug my grpc methods. And I
finally find that letmegrpc impl most of my feature, I am reading through
letmegrpc now and doing some changes.
So, I think I can provide a PR to solve this issue.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#52 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABvsLVSZ-FofU_Yb90fpQMKC1-3NltC6ks5u7ExugaJpZM4Zbn_J>
.