Create CI test that ensure generated files have not changed

Question

Create CI test that ensure generated files have not changed

johanbrandhorst opened this issue 6 years ago · comments

Johan Brandhorst-Satzkorn commented 6 years ago

It can use the scripts from gogo/googleapis as mentioned in #4 (comment).

This should include splitting the third_party folder generation assets into a separate Makefile job as it is generation-time dependant.

Walter Schulze · Answer 1 · Sun Feb 25 2018 18:44:34 GMT+0800 (China Standard Time)

Sounds good.

Are you able to create a travis job, now that you are a member of gogo?

Johan Brandhorst-Satzkorn · Answer 2 · Sun Feb 25 2018 19:41:09 GMT+0800 (China Standard Time)

I added Travis to the repo but when I triggered a build it failed. I will look into it later, a bit busy today. Feel free to fix it if you know what's missing. I have no prior experience with Travis.

Walter Schulze · Answer 3 · Sun Feb 25 2018 20:08:24 GMT+0800 (China Standard Time)

Take your time.

Is there some other free builder you do have experience with?

Johan Brandhorst-Satzkorn · Answer 4 · Sun Feb 25 2018 22:04:47 GMT+0800 (China Standard Time)

I use an advanced CircleCI setup to test the GopherJS gRPC-web bindings, but I want to learn to use Travis too :).

Walter Schulze · Answer 5 · Sun Feb 25 2018 22:09:35 GMT+0800 (China Standard Time)

I have heard good things about circle ci, so it is definitely an option instead of travis, but your choice.

…

On Sun, 25 Feb 2018, 15:04 Johan Brandhorst, ***@***.***> wrote: I use an advanced CircleCI setup to test the GopherJS gRPC-web bindings, but I want to learn to use Travis too :). — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#5 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABvsLfGubAuAJRRQN9x4uN1FDecKzpu8ks5tYWh_gaJpZM4SSPOr> .