godotengine / godot-vscode-plugin

Godot version

Godot Engine v4.3.dev.custom_build.d3352813e

VS Code version

1.86.0

Godot Tools VS Code extension version

Latest from master branch

System information

Windows 11

Issue description

I think that this Godot Engine commit:
godotengine/godot@f7f51bd

may be breaking the pattern matching code found here:

godot-vscode-plugin/src/utils/project_utils.ts

Line 84 in e2f2dc4

const pattern = /^Godot Engine v(([34])\.([0-9]+)(?:\.[0-9]+)?)/;

The match appears to fail every time now that the Godot help output is in color.

I know this isn't even a dev release, but I'm throwing this out here now so we can get ahead of it.

I will update this issue if the next Dev snapshot does or does not also break it. I assume this new code will stay though.

Steps to reproduce

Build the latest version of Godot Engine from the master branch and use it with this extension.

Changing the line to this appears to fix the problem:

const pattern = /^.*Godot Engine.*v(([34])\.([0-9]+)(?:\.[0-9]+)?)/;

This is such a trivial change I hesitate to make a PR, but I can if you want.

Also, it might be worth holding off until 4.3 is at least in Beta or Dev and confirm that the new output is final.

Hey, thanks for catching this!

Your proposal works, but my gut says it would be better to strip the non-printable[1] characters from the string first and then use the existing regex. .* is a lot of freedom that I don't necessarily want to allow.

Also, it might be worth holding off until 4.3 is at least in Beta or Dev and confirm that the new output is final.

I agree, let's wait a bit and see if they add anything else.

[1] terminal colors and other control functions are done using https://en.wikipedia.org/wiki/ANSI_escape_code, which are (more or less) ASCII characters that do not have printable representations.

Your proposal works, but my gut says it would be better to strip the non-printable[1] characters from the string first and then use the existing regex. .* is a lot of freedom that I don't necessarily want to allow.

Also, it might be worth holding off until 4.3 is at least in Beta or Dev and confirm that the new output is final.

I agree, let's wait a bit and see if they add anything else.

[1] terminal colors and other control functions are done using https://en.wikipedia.org/wiki/ANSI_escape_code, which are (more or less) ASCII characters that do not have printable representations.

Yep, totally makes sense. I was just using the simplest fastest approach. Since this is only here as a mild help to the user, I figured if it accidentally flags something as "OK" when it isn't wouldn't be the end of the world.
That and until it goes to at least a Dev release or maybe Beta, it could change.

As discussed a bit over here #586 (comment) the whole thing is a bit weird anyway. In theory one would use something like --version but that isn't super helpful either.

It would be nice if the Godot Engine had a documented API for finding the full version string, but that may be asking too much right now.

If I happen to come up with a fancier version I'll make a PR, but don't wait on me.

@chrisl8 We decided to just go back to using --version, which doesn't have colors and thus, doesn't have these problems.