godaddy / node-cluster-service

Turn your single process code into a fault-resilient, multi-process service with built-in REST & CLI support. Restart or hot upgrade your web servers with zero downtime or impact to clients.

https://www.npmjs.org/package/cluster-service

http-server.js should always res.end();

jsdevel opened this issue 10 years ago · comments

Joe Spencer commented 10 years ago

Observe: https://github.com/godaddy/node-cluster-service/blob/master/lib/http-server.js#L158

Aaron Silvas commented 10 years ago

There's no known case where res.end is not called. The extra fail safe is due to the severity of allowing the master to crash.