godaddy / node-cluster-service

Turn your single process code into a fault-resilient, multi-process service with built-in REST & CLI support. Restart or hot upgrade your web servers with zero downtime or impact to clients.

Home Page:https://www.npmjs.org/package/cluster-service

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"restart" hangs if "workerReady" is not invoked

asilvas opened this issue · comments

Leveraging workerReady for highly asynchronous services is very handy, but there needs to be a simpler default path that does not require path. Add a new option workerReady that indicates if we should wait for ready event before continuing. Setting this option to false as the default will be a breaking change, but it needs to be done as the service gets to be more stable.

Since this defaults to false, making the "workerReady" optional, it is an important but breaking change.