gocraft / work

Process background jobs in Go

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

RediGo Nil Returned

caldempsey opened this issue · comments

Hi GoCraft maintainers

In my logs I'm seeing Redigo nil returned in cases where this returns, well nothing.

work/worker.go

Line 241 in 61759fb

logError("worker.delete_unique_job.get", err)

This is possible when there really isn't anything to get! gomodule/redigo#355

So I believe this is an edge case where we can ignore the error and return nil,nil in the response (no unique job exists/nothing to get).

How do you guys feel about this? Should I open a PR?

Update, this occurs when there are items in the "dead" and "reply" queue that return errors in jobs!