Add support for ClickHouse driver
santileira opened this issue · comments
Hey, I'm Santiago Leira and I work at Embrace as a Software Engineer.
At Embrace, we did a fork of the library and we added support for ClickHouse and we would like to contribute to the main repository with this integration.
Do you have the contribution guide to know how can we add support to ClickHouse here?
Thanks
@cypriss or @taylorchu as you are the authors of this library. Thanks
I think you can start with a dialect here: https://github.com/gocraft/dbr/tree/master/dialect
then add clickhouse to the list here: https://github.com/gocraft/dbr/blob/master/dbr_test.go#L37
clickhouse is surprisingly similar to mysql in its query.
@taylorchu PR is ready here #264 I cannot make circleci run because I'm not a user of the org, I guess. Is that something you can trigger? Locally, tests pass
could you register on circleci and see if that unlocks you?
I did register, with the same email I use for github, and linked my github account too, but it still shows block-unregistered-user
on circle ci
I wonder if it's because it doesn't have access to our org embrace-io
@taylorchu I managed to get circleci running. Seemed that my github integration was not ok. Fixed one test that was failing and had to upgrade circleci golang image as it was outdated. Tests are passing now, so it's ready to be reviewed. Thanks in advance!