goatcorp / Dalamud

FFXIV plugin framework and API

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

IsValidCharacterName doesn't handle long names

kalilistic opened this issue · comments

commented

There are people with longer names than 20 combined which means the IsValidCharacterName method may return false on some valid characters. Sounds like client has space up to 32 characters in most places. Could change the length. Maybe swap over to the cs check at the same time. In discord, goat recommended having a toggle for legacy name support.

https://github.com/kalilistic/Dalamud/blob/dbd59ebe91a2968960af90e142ac2c6f1c2028fa/Dalamud/Utility/SeStringExtensions.cs#L27
aers/FFXIVClientStructs#381

image