OnBeforeRequest and default middleware order documentation and code mismatch
leejuyuu opened this issue · comments
Tzu-Yu Lee commented
The documentation of OnBeforeRequest
Lines 403 to 405 in 3d08b36
says that the middleware set by this function is applied after the default middlewares.
However, when the request is executed, the order is reversed.
Lines 896 to 912 in 3d08b36
I think this resulted in #517.
I am not sure which side is the intended result.
Jeevanandam M. commented
@leejuyuu Thanks for bringing it up. I didn't notice it. The documentation needs correction. I will correct it, or you could submit the PR. Please let me know.
As @0140454 mentioned in the #517 (comment), this is the correct order of execution.
Tzu-Yu Lee commented