NewRef should return an empty Ref if refURI is empty

Question

NewRef should return an empty Ref if refURI is empty

nikhita opened this issue 7 years ago · comments

We are using go-openapi for validation of Custom Resources in Kubernetes (kubernetes/kubernetes#47263).

While using the spec.NewRef function, an empty string i.e spec.NewRef("") results in a Ref with a # - not an empty Ref value. Due to this, we incorporated an additional check.

Looking at the code in https://github.com/go-openapi/jsonreference, it looks like an empty Ref should be produced but I couldn't really figure out why that does not occur.

cc @sttts

Ivan Porto Carrero · Answer 1 · Mon Jul 31 2017 00:21:03 GMT+0800 (China Standard Time)

It's because of this this line: https://github.com/go-openapi/spec/blob/master/ref.go#L141

Ivan Porto Carrero · Answer 2 · Mon Jul 31 2017 01:39:21 GMT+0800 (China Standard Time)

would it be ok if it returned:

{"$ref":""}

Nikhita Raghunath · Answer 3 · Mon Jul 31 2017 01:53:03 GMT+0800 (China Standard Time)

@casualjim That would be perfect, thanks. 👍

Ivan Porto Carrero · Answer 4 · Mon Jul 31 2017 01:54:00 GMT+0800 (China Standard Time)

i fixed this now so please close when you've confirmed :)