Fix Go 1.9 and earlier tests

Question

Fix Go 1.9 and earlier tests

johnweldon opened this issue 3 years ago · comments

Dependency on github.com/Azure/go-ntlmssp should either be pinned to a passing version, or we decide if we want to drop testing for pre-1.10 versions? I'd prefer the former option. ( See discussion on #352 )

Christopher Puschmann · Answer 1 · Wed Jan 05 2022 05:25:51 GMT+0800 (China Standard Time)

Personally, I'd prefer the latter one as well. Also, since the last release of go1.10.x, multiple security patches + fixes have been applied to the std libs. For example:

John Weldon · Answer 2 · Wed Jan 05 2022 05:29:13 GMT+0800 (China Standard Time)

Okay, let's drop support for Go 1.9 and earlier.

Christopher Puschmann · Answer 3 · Sat Mar 12 2022 21:34:33 GMT+0800 (China Standard Time)

I suggest v1.13, since go-asn1-ber uses this version as well

@johnweldon Are you ok with this? If you greenlight this I'll make a PR

John Weldon · Answer 4 · Wed Apr 06 2022 08:44:08 GMT+0800 (China Standard Time)

I thought I'd responded to this... sorry... yes I'm okay with v1.13+