v3.1.1 contains breaking changes

Question

v3.1.1 contains breaking changes

emersion opened this issue 5 years ago · comments

Simon Ser commented 5 years ago

f252a88 is a breaking change. This breaks builds.

Simon Ser commented 5 years ago

Thanks!

Kaleb Elwert · Answer 1 · Fri Mar 13 2020 23:51:38 GMT+0800 (China Standard Time)

I’m unsure what the best path forward would be here. As, unlike most other package systems, you cannot revoke versions. Optimally I think I would have revoked 3.0.0 as it had numerics I don’t want to support in there. I’ll have to take a closer look when I’m at a computer.

Kaleb Elwert · Answer 2 · Fri Mar 13 2020 23:52:40 GMT+0800 (China Standard Time)

I’d be fine releasing a new major version, but then I’d want to fix the issue with hanging and potentially change the method signature of a few functions as well.

Simon Ser · Answer 3 · Sat Mar 14 2020 00:10:11 GMT+0800 (China Standard Time)

I think a reasonable path forward would be to un-do the breaking changes with a bugfix version, then prepare a new major version with all the breaking changes. This would allow existing users to upgrade safely.

Kaleb Elwert · Answer 4 · Sat Mar 14 2020 01:23:31 GMT+0800 (China Standard Time)

I've added back sections for obsolete RFC1459 and RFC2812 commands. I believe these are the 16 that were removed in the previous commit. I've tagged it v3.1.2. Next breaking change will probably be fixes for the Client and will include a major version bump.

Thanks for mentioning this!