Support for gogs/gitea
tonivj5 opened this issue · comments
Thanks for maintaining this project!
any news?
I think Gitea will integrated it internal not a separated service.
That's a great new :-)
@lunny I would much rather see it as a separate service though. Unless we get "Approvals" integrated into CodeReview :)
@bkcsoft Yes, I mean that.
I'm thinking on creating approval system like in GitLab but without code review and approvals stored in database in coming weeks
@lafriks I like the github's approvals but I think it's need an approvals number on repository settings.
Yes, that's what I'm also plan to add. When I have something to show I will create wip PR
@lafriks External integration is fine, internal integration is not very KISS
Yes but internal can do a lot more and will be more reliable
@bkcsoft I don't think so.
For Gitea's users, KISS means don't let me change this site to other site. Both internal or external integrations are OK.
For Gitea's manager, KISS means less maintain things(one binary/one service) since current Gitea's objective is for small teams or organizations.
Maybe it could be integrated into Gitea as well as run as a seperated service.
I agree with @lunny that it can be both internal or external but in both cases in gitea there should be some kind of infrastructure to store approval count/info and limit PR merging before approval conditions are met
gitea has it build in ...