Building with `-Werror` breaks certain libraries
GabrielMajeri opened this issue · comments
This source line enables -Werror when building. This breaks the libz-sys crate's build process.
Is there any reason for enabling -Werror? Should it be made optional? Fixing the original C libz is another possibility, although that is a harder path.
This is unfortunate :(
Right now this library relies on -Werror to work at all (otherwise the C compiler just emits warnings for everything we want to be an error). Maybe a more targeted -wno-foo-bar can be used here instead?
Found the actual issue, ctest didn't give a false positive, this was an actual bug. Closing for rust-lang/libz-sys#32.