Giters

gnuradio / volk

The Vector Optimized Library of Kernels

Home Page:http://libvolk.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

volk_8u_conv_k7_r2puppet is broken

argilo opened this issue · comments

commented

volk_8u_conv_k7_r2puppet, which tests the volk_8u_x4_conv_k7_r2_8u kernel, has its input and output arguments (dec & syms) reversed. As a result, it always tests volk_8u_x4_conv_k7_r2_8u with syms = [0, 0, ... 0], which is a very poor test input and has allowed serious bugs to slip through, like the one fixed in #458.

If the argument order is fixed, then even the spiral protokernel begins failing. I'm having a look now to see why its behaviour differs from the generic protokernel.