Add i386 to CI

Question

Add i386 to CI

argilo opened this issue 6 months ago · comments

Clayton Smith commented 6 months ago

Running VOLK's test suite on i386 revealed a broken protokernel and many broken tests:

Given this success, it would seem useful to add i386 to CI to catch more future bugs.

Johannes Demel · Answer 1 · Sun Dec 10 2023 22:57:49 GMT+0800 (China Standard Time)

Looking at the fixes, I agree.

Johannes Demel · Answer 2 · Sun Dec 10 2023 23:08:59 GMT+0800 (China Standard Time)

I'm looking for a way to run i386. A native GH Action would be preferable because they are much faster. I do have some hope that MacOS13 arm64 images do that for us on MacOS.

For non-x86, we use run-on-arch. This action doesn't provide an i386 image.

Clayton Smith · Answer 3 · Sun Dec 10 2023 23:11:36 GMT+0800 (China Standard Time)

GNU Radio uses a 32-bit container: https://github.com/gnuradio/gnuradio/blob/bdaf5df2bd26325864d66bfb04caf8c8617296d1/.github/workflows/make-test.yml#L100-L102

Clayton Smith · Answer 4 · Sun Dec 10 2023 23:28:58 GMT+0800 (China Standard Time)

Another way of catching floating-point bugs might be to use a tool like https://github.com/verificarlo/verificarlo.

But an i386 build still would have been needed to catch #714.