Firejail fails improperly – causing false reportings.
gnunicorn opened this issue · comments
When the process inside firejail dies, firejail does not bubble up the exit code – it only uses it to reference its own execution. Which means that we are reporting failing exection as "success" at the moment. For example on ourselfes because OpenSSL is causing hickups again:
For this particular error, checking if any line starts with "error" would allow us to identify it. But with the latest changes to limit resource ( #18 ) this might not always be the case.
I have to investigate how reliable the Process X dead! message from firejail is – maybe we can use that as an indicator.
It appears that does not always happen: http://clippy.bashy.io/github/sha/semantic-rs/semantic-rs/6588cacc9f6318602b726d13272605fabf099fa2/log
Maybe -c does the trick?
-c Execute command and exit.
nope. firejail always swallows it. Filed an issue with them (see above) offering to fix it. If that doesn't go anywhere, we might have to find a different solution.
Filed a bug, created a PR and it got merged – netblue30/firejail#363 . Firejail is on the way to give us proper return codes. Let's see how long before the next release and once we have that, we are good!