Giters

gnosisguild / zodiac

A library for composable tooling for onchain entities

Home Page:https://gnosisguild.org

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Latest release is broken due to patch-package

compojoom opened this issue · comments

commented

Describe the bug
I guess I broke it :(

[4/4] 🔨  Building fresh packages...
⠁
⠁
⠁
error /node_modules/@gnosis.pm/zodiac: Command failed.
Exit code: 127
Command: patch-package
Arguments:
Directory: /node_modules/@gnosis.pm/zodiac

Adding patch-package at the post-install step was a mistake as yarn is trying to execute that step even when installing the package as a dependency. Maybe we should try moving it to generate types step which is called when trying to make a build, so no post install will be called when adding the package to other pojects.

To Reproduce
just try to yarn add the package

Expected behavior
To succeed.

Screenshots / logs
If applicable, add screenshots and/or logs to help explain your problem.

Relevant environment details:

  • OS: [e.g. iOS]
  • Browser [e.g. chrome 22, safari]
  • Node version [e.g. 14.17.4]
  • etc

Additional context
Add any other context about the problem here.