gmarty / DVD.js

Playing DVD in JavaScript for the sake of interoperability

Home Page:http://gmarty.github.io/jsconf-2014-talk-play-dvd-in-js/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

"Play" menu

divergentdave opened this issue · comments

Is the DVD selection menu still a work in progress? I get an error when I click on the "Play" button. It looks like the templating code should be $('.video-container').html(_.template(list)({dvds: data})); instead of $('.video-container').html(_.template(list, {dvds: data}));. I don't see where the cover.jpg files come from, are those supposed to be user-supplied? Thanks!

Hi!
The template line looks good to me. I'll update the code to use precompiled template instead.
And yes, the cover.jpg must be supplied by the user.

The change is here: d6418cc

Let me know if you still have the issue. Also this change shouldn't conflict with your current PR :-)