Doesn't cleanup GLSL code in output string

Question

Doesn't cleanup GLSL code in output string

ajayns opened this issue 4 years ago · comments

The plugin should not only support imports using glslify but strip the code of comments, formatting and minify into a string.

This is performed by rollup-plugin-glsl maybe we could port the feature over from there?

Patrick Schroen · Answer 1 · Fri Mar 13 2020 22:47:01 GMT+0800 (China Standard Time)

Agreed, considering the compress option should default to true as well.

Patrick Schroen · Answer 2 · Sun Mar 15 2020 10:45:53 GMT+0800 (China Standard Time)

Published rollup-plugin-glslify@1.2.0. If you can verify it's working the same as rollup-plugin-glsl. Thanks!

Aj · Answer 3 · Mon Mar 16 2020 12:01:45 GMT+0800 (China Standard Time)

This looks good! I just found that a line \n#define GLSLIFY 1\n is injected in the string as compared to the output from rollup-plugin-glsl. I haven't tested it out on a project yet, but it looks like harmless code coming in from glslify.

Since it does look like it's doing the job right, I'll close the issue. Thanks a bunch @pschroen for your fast resolution and the API for it looks neat too.