globocom / megadraft

-- Bug Report --

Expected Behavior

The blockComponent shouldn't be re-created all times

Current Behavior

Since the version 0.7.0 the blockComponent is always re-created when you write a special character like ê, ë (combinaison of two keyboard keys to being added).

Steps to Reproduce

Go to : https://codesandbox.io/s/megadraft-with-plugins-and-example-content-forked-ck83pb?file=/src/index.js

Open the console, you see one ImageButton mount ... and ImageBlock mount ...
Type something in the editor you, nothing happened in the console
Now type character ê multiple times and see the console, the ImageBlock component is re-created for each character...
Downgrade the version of megadraft under the 0.7.0, and type the special character, you can see the expected behavior

Browser, device, and OS

Screenshots

Update: It seem's that the problem still comes with the version under 0.7.0. for this scenario :

Create a new empty block by pressing ENTER key (to create new paragraph)
Begins by typing the special char ê

You'll see again the ImageBlock re-mounting.

ImageBlock gets added as a plugin here:

megadraft/src/components/MegadraftEditor.js

Line 121 in 1caecd3

for (let plugin of this.props.plugins || DEFAULT_PLUGINS) {

by default if you don't specify it as a plugin. What happens for you if you don't specify any plugins?

I also looked at the keybindings and couldn't find any default bindings that could cause this issue for you. I also couldn't replicate it myself

ALso, noticed opportunity for minor improvement on these components so opened a PR for them: #406