glitch100 / BinanceDotNet

Official C# Wrapper for the Binance exchange API, with REST and WebSocket endpoints

Home Page:https://www.nuget.org/packages/BinanceDotNet/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

New PERCENT_PRICE ExchangeInfoSymbolFilter type

xucito opened this issue · comments

commented

Issue Overview

There is a new ExchangeInfoSymbol called Percentage_Price that throws a error during deserialization.

Repro Steps

GetExchangeInfo() using the currently released API.

Other Information

Other information here

will this change also update the nuget package finally?

commented

The owner of the nuget package needs to update the nuget package with the fix.

all good. sorry i wasnt aware of that. ive made changes locally on my own machine to fix any outstanding crashes in any case. but i'm also going to email binance support, because they should really increase their url version to v2, v3 etc when they change the interface. And email all users who have an API key so we are aware of changes, rather than finding out by our apps crashing :(

Is this still happening? If you could put up a PR that would be great 👍

Yes it's still valid issue

// Assembly: BinanceExchange.API, Version=4.7.0.0, Culture=neutral, PublicKeyToken=null

  public enum ExchangeInfoSymbolFilterType
  {
    [EnumMember(Value = "PRICE_FILTER")] PriceFilter,
    [EnumMember(Value = "LOT_SIZE")] LotSize,
    [EnumMember(Value = "MIN_NOTIONAL")] MinNotional,
    [EnumMember(Value = "MAX_NUM_ORDERS")] MaxNumOrders,
    [EnumMember(Value = "MAX_NUM_ALGO_ORDERS")] MaxNumAlgoOrders,
    [EnumMember(Value = "ICEBERG_PARTS")] IcebergParts,
  }

There is no "PERCENT_PRICE" value. Could you please merge the PR?

I can and will get it merged today or tomorrow - is that alright? 👍

And update Nuget package? It will be perfect. Thanks in advance.

Done 👍 @khmurach

Now it works fine. Thanks, @glitch100!