Non default values

[Frédéric Yhuel]

pgstats/pgreport_queries.h

Line 5 in d03a048

 #define SETTINGS_NOTCONFIGFILE_NOTDEFAULTVALUE_SQL "SELECT source, name, setting, unit FROM pg_settings WHERE source NOT IN ('configuration file', 'default') ORDER BY source, name" 

Do we want that instead?

SELECT source, name, setting, unit FROM pg_settings WHERE source NOT IN ('configuration file', 'default') OR (boot_val != reset_val) ORDER BY source, name;

[Guillaume Lelarge]

I think both are right. Do you have an example where adding the OR clause changes the results?

[Frédéric Yhuel]

For example, if you set shared_buffers to a non default value in the postgresql.conf file.

[Guillaume Lelarge]

I just checked and I think you're right. Do you care to do a PR? otherwise, I'll fix it tomorrow. I have to go back to my hotel now. Need some sleep :-)

[Frédéric Yhuel]

Done. Good night :)

[Guillaume Lelarge]

Thank you, the PR is merged.