glebm / rails_email_preview

Preview and edit app mailer templates in Rails.

Home Page:http://glebm.github.io/rails_email_preview

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Support rails 5.0

opened this issue · comments

I did an exercise running rails_email_preview latest with rails 5.0.0.beta1. It sort of worked for me after some fiddling.

I found places handling request parameters all needed to do hash conversion before use (e.g params.to_unsafe_h). Ref: http://eileencodes.com/posts/actioncontroller-parameters-now-returns-an-object-instead-of-a-hash

I also tested Comfortable Mexican Sofa editing integration, it worked after I changed comfortable_mexica_sofa.rb (send become Rails.application.routes.url_helpers.send) to fixed an undefined comfy _path error. The route of "comfy_route :cms" caused errors so I specified them manually (e.g get '/cms/cms-css/:site_id/:identifier(/:cache_buster)(.:format)' => 'comfy/cms/assets#render_css', as: 'comfy_cms_render_css')

The non-CMS part has been released in v1.0.3! Feel free to submit the PR for the CMS if it doesn't work.