Question about Account endpoint implementation

Question

Question about Account endpoint implementation

chriske opened this issue 2 years ago · comments

First of all, I'd like to thank you for your work, this application is amazing!

I made a PoC integration with your application for one of my clients: I wanted to integrate it with cert-manager (https://cert-manager.io/). If you are not familiar with it, it can request and renew certificates in a Kubernetes environment with ACME protocol.

I was able to integrate it with your application, but when I wanted to request a new certificate, I found in the IIS logs, that the app throws a NotImplemented exception for the Account endpoints. I'm not familiar with the implementation details of ACME protocol (I don't know that these endpoints are neccessary or not), but I would like to ask: will you implement these endpoints as well in the future?

Thanks for your answer in advance

Thomas Ottenhus · Answer 1 · Fri Aug 19 2022 00:18:13 GMT+0800 (China Standard Time)

Hey, I'll check it - the software should be compliant with the ACME-RFC. And I successfully issues certificate already. But I might not have uploaded the latest build to release. I'll get around to it this weekend, I'd suppose.

Inotay Krisztián · Answer 2 · Fri Aug 19 2022 02:19:56 GMT+0800 (China Standard Time)

Hey, thanks for the response!

These are the methods what I'm talking about:

https://github.com/glatzert/ACME-Server-ACDS/blob/8b459f8b5a06fec15089a5b0eb61705a5e8da547/src/ACME.Server/Controllers/AccountController.cs#L52

Thomas Ottenhus · Answer 3 · Fri Aug 19 2022 15:30:38 GMT+0800 (China Standard Time)

To be fair, I never used that function. Nevertheless, they’ll get implemented :) I wonder why your tool uses them …

Thomas Ottenhus · Answer 4 · Tue Aug 23 2022 15:11:59 GMT+0800 (China Standard Time)

I took a first look into the "FindAccount" functionality.
It should not be triggered, if the tool does not submit "existingAccountOnly" (a parameter controlling, if you create or look for an account). Nevertheless it might do that before creation to not run into an error, if the account already exists (but into an error, if it does not).

The implementation of that functionality is a little bit more work than anticipated, which esentially is my fault, since I did not use SQLite for storage, but the harddrive AND decided to use a folder named by the accountId.

I'll have to do a little rewriting to fix that problem, so I'll need another week.

Thomas Ottenhus · Answer 5 · Fri Oct 28 2022 17:32:25 GMT+0800 (China Standard Time)

I implemented the function.
But I had not time to check it in a real environment