Add automatic module name manifest entry
gkopff opened this issue · comments
@spegelref You added the bits and pieces to make this OSGi aware. I wondered if you knew what the right thing to do is with regards to OSGi + JPMS?
The simplest first step towards supporting JPMS is to add an automatic module name entry to the MANIFEST.MF
.
However, it looks like just configuring the maven-jar-plugin
to do it, like so:
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.0.2</version>
<configuration>
<archive>
<manifestEntries>
<Automatic-Module-Name>com.fatboyindustrial.gson-javatime-serialisers</Automatic-Module-Name>
</manifestEntries>
<manifestFile>${project.build.outputDirectory}/META-INF/MANIFEST.MF</manifestFile>
</archive>
</configuration>
</plugin>
... doesn't work when bnd-maven-plugin
is involved in creating the manifest.
Any ideas how to get bnd-maven-plugin
and maven-jar-plugin
to place nicely together?
Sorry been off github for some time.
If the only thing you need is to add the line: Automatic-Module-Name: com.fatboyindustrial.gson-javatime-serialisers
into the META-INF/MANIFEST.MF then you could add it in the bnd.bnd file and bnd plugin will include it.