Giters

gklijs / schema_registry_converter

A crate to convert bytes to something more useable and the other way around in a way Compatible with the Confluent Schema Registry. Supporting Avro, Protobuf, Json schema, and both async and blocking.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Have a way to leave out the full_name for the Proto Encoder

gklijs opened this issue · comments

commented

Is your feature request related to a problem? Please describe.
Currently the full_name is always needed in the proto raw encoded. This is additional hassle and prone to errors, also it's causing a little additional overhead.

Describe the solution you'd like
There should be an encode without the full_name, but that can only be used id the message use is the first message defined. Using references this is very much possible, and also how I figured out this might be the default use.
Possibly we could throw an error if the method without the full name is used, but the resolved proto file does contain multiple messages.

Describe alternatives you've considered
Just using it with the name, but it's an hassle when the proto file only contains one message.

Additional context
As you can see in https://github.com/gklijs/ksqlDB-GraphQL-poc/blob/3670101fd36f2223dfed094601f525bb48a09b5b/rust-data-creator/src/kafka_producer.rs#L17 it's quite some hassle.

commented

I could easily fix this, but would like to know how useful it's to others.