EdgeRepository - update Edge

[clepelli]

Hello again,

Updating an edge via the SimpleGremlinRepository always fails, throwing "Schema is neither EDGE nor VERTEX!".

Actually there is a typo there:

spring-data-gremlin/spring-data-gremlin-core/src/main/java/org/springframework/data/gremlin/repository/SimpleGremlinRepository.java

Line 120 in 126efb2

 } else if (schema.isVertexSchema()) { 

Best regards,
Clément.

[clepelli]

Then, we should remove the cascade when the Edge is updated as the vertices may not be loaded. Below is my quick local rewriting of the method discussed above.

@Transactional(readOnly = false)
public T save(Graph graph, T object) {

    String id = schema.getObjectId(object);
    if (StringUtils.isEmpty(id)) {
        create(graph, object);
    } else {
        Element element;
        if (schema.isVertexSchema()) {
            element = graph.getVertex(schema.decodeId(id));
            schema.copyToGraph(graphAdapter, element, object);
        } else if (schema.isEdgeSchema()) {
            element = graph.getEdge(schema.decodeId(id));
            Object outObject = ((GremlinEdgeSchema) schema).getOutProperty().getAccessor().get(object);
            Object inObject = ((GremlinEdgeSchema) schema).getInProperty().getAccessor().get(object);
            schema.copyToGraph(graphAdapter, element, object, outObject, inObject);
        } else {
            throw new IllegalStateException("Schema is neither EDGE nor VERTEX!");
        }
        if (element == null) {
            throw new IllegalStateException(String.format("Could not save %s with id %s, as it does not exist.", object, id));
        }
    }
    return object;
}

[Graham Webber]

Fixed in 11ee40b. Thanks clepelli!