gizatechxyz / orion

ONNX Runtime in Cairo 1.0 for verifiable ML inference using STARK

Home Page:https://orion.gizatech.xyz

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

dev: Replace Orion Signed Int with Cairo Signed Int

raphaelDkhn opened this issue · comments

Cairo corelib supports now Signed Integers. We should replace Orion signed integers with Corelib signed integers.

can you give more explanation on which files should change and general requirements for implementation?
and from which version of Cairo signed integer is implemented?

This involves a deep refactoring of Orion. When Orion was implemented, signed integers were not yet supported in Cairo. So we had to implement our own signed integer implementation. Now, Cairo supports Signed Ints.

  • IntegerTrait should be removed.
  • NumberTrait should be refactored to
  • Tensor and NN operators should be refactored to support native signed ints
  • Tests should be updated
  • Doc should be updated

Ok I'll take this