giusgad / pets.nvim

Display pets in your editor 🐱

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Searching for new assets - licensing problem

giusgad opened this issue · comments

As you might have noticed, there was a licensing problem with the assets used until now, it was my error since I made wrong assumptions based on others that had a similar situation. If you still have the assets I kindly ask you to remove them and if you want to keep using them buy the pack, and I'll show you how to set them up locally on your machines.

From now on I will be searching for a new asset pack, if you have any suggestion, or if you are an artist and you want to create some, feel free to reach out below.

I'm deeply sorry for this huge mistake.

I was out for the week-end and did not see your response. I was deeply sorry to see my cat not appearing on my screen this morning.
This licensing issue was brought-up to vscode-pets (here's the issue) and there was a larger conversation on the artist's website concerning the situation (here's the conversation thread).

The author of vscode-pets found a way to bundle the assets in an encrypted file to which only he has the password to and it seems that the solution was ok for seethingswarm as seen in the conversation thread.

Do you think such a solution could be applied here ?

I did not take the time to see how it was done in vscode-pets but I guesss their architecture could be replicate here.

I did check out how it was done on their side, but I'm not sure it's possible with neovim. The author of vscode-pets seems to have packaged the assets in an encrypted zip folder. From my understanding, the zip gets decrypted when he creates the “release” or similar for vscode's extension market. I therefore do not think it's possible to achieve the same result in neovim since our "extension market" is just plugin being downloaded directly from GitHub and there is nothing in between.
I hope I'm wrong, but I don't have any idea on how this could possibly be achieved, if anyone with more expertise knows please let me know.
Meanwhile, I'm working on getting some new dog assets from another site that seem to have a more permissive license.

Added dogs in add39bd 🎉

I still want cats on my screen...

@vtvz If you still want the cats you can buy the assets independently and then follow these steps to set them up:

  • rename the catset_gifs folder to cat
  • install dependencies for the script: perl-rename gifsicle convert (from ImageMagick)
  • run this script to set up the assets
  • find where the plugin is installed (like .local/share/nvim/lazy/pets.nvim)
  • copy the cat folder from where you had the assets to the media foldere in the plugin
  • add ./lua/pets/pets/cat.lua with this content:
return {
    next_actions = {
        crouch = { "crouch", "crouch_left", "idle", "idle_blink", "liedown", "sneak" },
        crouch_left = { "crouch_left", "crouch", "idle", "idle_blink", "liedown", "sneak_left" },
        idle = { "idle", "idle_blink", "walk", "walk_left", "run", "run_left", "liedown", "sit" },
        idle_blink = { "idle_blink", "idle", "walk", "walk_left", "run", "run_left", "liedown", "sit" },
        liedown = { "liedown", "sneak", "sneak_left", "crouch", "crouch_left", "sit", "idle", "idle_blink" },
        run = { "run", "walk", "run_left" },
        run_left = { "run_left", "walk_left", "run" },
        sit = { "sit", "liedown", "idle", "idle_blink" },
        sneak = { "sneak", "sneak_left", "crouch", "liedown" },
        sneak_left = { "sneak_left", "sneak", "crouch_left", "liedown" },
        walk = { "walk", "walk_left", "run", "idle", "idle_blink" },
        walk_left = { "walk_left", "walk", "run_left", "idle", "idle_blink" },
    },
    idle_actions = { "idle", "idle_blink", "liedown" },
    first_action = "idle",
    movements = {
        right = {
            normal = { "walk" },
            fast = { "run" },
            slow = { "crouch", "sneak" },
        },
        left = {
            fast = { "run_left" },
            normal = { "walk_left" },
            slow = { "sneak_left", "crouch_left" },
        },
    },
    get_death_animation = function(_)
        return "die"
    end,
}

Would these cats be acceptable?
https://opengameart.org/content/cat-sprites
The assets appear to be in the public domain.