gitleaks / gitleaks

Protect and discover secrets using Gitleaks 🔑

Home Page:https://gitleaks.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect Start and End Column Values in Gitleaks Report for Findings

dxbluff opened this issue · comments

Description:
When Gitleaks generates a report for detected secrets in large one-liner files exceeding 10000 symbols, the start column and end column values are inaccurately calculated. Specifically, in such cases, the start column is reported as 2245, whereas the correct value should be 12245. It appears that the calculation is currently performed using modulo 10,000, resulting in inaccurate start and end column values.

Expected Behavior:
The start column in the Gitleaks report for large one-liner files should accurately reflect the position of the first character of the detected secret. In cases where the line exceeds 10000 symbols, the start column should be calculated correctly, considering the extended length of the line.

Current Behavior:
The start column value in the report does not align with the actual position of the secret in large one-liner files exceeding 10000 symbols, resulting in a discrepancy (e.g., reported start column: 2245, expected start column: 12245).

Steps to Reproduce:

  • Identify a repository with large one-liner files containing secrets exceeding 10000 symbols.
  • Run Gitleaks on the repository.
  • Review the generated report for detected secrets in large one-liner files.
  • Note the start and end columns for findings in files longer than 10000 symbols.

Gitleaks Version: 8.18.2