github / relative-time-element

Web component extensions to the standard <time> element.

Home Page:https://github.github.io/relative-time-element/examples/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stray days added to duration

TymekDev opened this issue · comments

Hey, I am having an issue where the relative time between 2022-07-11T09:00:00+02:00 and 2023-07-11T09:00:00+02:00 is 1 year, 5 days instead of 1 year. Similarly 2023-05-11T09:00:00+02:00 and 2023-07-11T09:00:00+02:00 are 2 months, 1 day where I'd expect it to be just 2 months. As I shorten or lengthen the difference between datetimes the days decrease or increase respectively.

I can think of possibilities at calculation level where these come from, however I find the human-readable duration confusing.

That does seem confusing. Would you kindly add a set of failing tests around here:

{
reference: '2023-03-23T12:03:00.000Z',
datetime: '2023-03-21T16:03:00.000Z',
format: 'relative',
tense: 'past',
expected: '2 days ago',
},

If you raise a PR where the expected is your desired text, and we can look at a fix.