github / relative-time-element

Web component extensions to the standard <time> element.

Home Page:https://github.github.io/relative-time-element/examples/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Mixed languages in '<relative-time>'

DominikPalo opened this issue · comments

Issues lists on GitHub have relative times displayed in two languages. For example, my os/browser is set to the Slovak language and when I open a GitHub issues list, some relative times are displayed as translated (red) and some in English (blue) - see the attached screenshot.

Browser: Google Chrome 74.0.3729.169
OS: macOS Mojave 10.14.4

github

The same problem occurs with me. Part of it is in Polish, in part in English.
Annotation 2019-06-02 134839

Hey @DominikPalo and @Faierbel 👋

I'm unable to reproduce this on my machine. Would you happen to have any Chrome extensions installed that could be causing this? Is this reproducible in Incognito Mode (or with extensions disabled).

I saw this 2 minutes ago as well (mix between Norwegian and English, didn't capture screenshot), but I'm unable to repro anymore 🤔 😕

I've just tried and it happens also in Incognito mode (with all Chrome extensions disabled). But I have to switch to the "Closed" tab and then back to the "Open" tab to replicate it - see the recording: https://gyazo.com/126ce5a0351f06af12f03d7116d69622

Managed to reproduce after a few refreshes on pulls, but not on issues:

image

BTW, I have lang="en" on the html tag, Accept-Language: en,nb;q=0.9 and navigator.languages => ["en", "nb"] 🤷‍♂

EDIT: Another BTW; why would you have i18n relative times, but have the rest of the application in English? Seems kinda weird.

I've figured out what is going on with all your help and am able to reproduce this. I'll try to have a fix going out soon!

We've downgraded the package on github.com until we fix the issue in github/time-elements so you should be seeing only english relative timestamps again. I'll keep this issue open until we've shipped a fix to the package.